Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnsupportedDevice Styling #76

Merged
merged 3 commits into from
Nov 25, 2024
Merged

UnsupportedDevice Styling #76

merged 3 commits into from
Nov 25, 2024

Conversation

jonryser
Copy link
Collaborator

@jonryser jonryser commented Nov 25, 2024 •
edited
Loading

Describe the changes

The UnsupportedDevice view didn't completely match the Figma.

  • The width of the content below the "Device Not Supported" should be just about the same width. Updated the width of those text blocks to always match the title width.
  • Updated the feature flag buttons to by styled like other buttons and always be the same width as each other.
  • Updated the PrimaryButton and SecondaryButton styles to accept an optional 'minWidth" parameter.

Was:
Simulator Screenshot - iPhone 16 - 2024-11-25 at 11 56 24

Updated to:
Simulator Screenshot - iPhone 16 - 2024-11-25 at 11 57 08

Issue ticket number and link

#8

@jonryser jonryser merged commit 2b83bca into release-20241118 Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stanley-Jovel Stanley-Jovel Stanley-Jovel approved these changes

@ThomasJones ThomasJones Awaiting requested review from ThomasJones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonryser @Stanley-Jovel