[86] Improve Chat Scrolling #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n a response is generating, showing a scroll to bottom button, 'sticking' scroll to bottom if user has explicitly scrolled down
ThomasJones
commented
Nov 27, 2024
| @@ -69,12 +69,46 @@ public struct TypingIndicator: View { | |||
| } | |||
| } | |||
|
|
|||
| struct ScrollState { | |||
| static let BottomScrollThreshold = 120.0 | |||
There was a problem hiding this comment.
This threshold is the magic sauce but should perhaps be generalized / scale by text size?
There was a problem hiding this comment.
That's a good idea!
Make the "body" font size a constant
jonryser
reviewed
Nov 28, 2024
OLMoE.swift/Views/ContentView.swift
Outdated
| func respond() { | ||
| isGenerating = true | ||
| Task { | ||
| let originalInput = input | ||
| input = "" // Clear the input after sending | ||
| await bot.respond(to: originalInput) | ||
| scrollToBottom = true | ||
| //scrollToBottom = true |
jonryser
reviewed
Nov 28, 2024
OLMoE.swift/Views/ChatView.swift
Outdated
| let isAtBottom = !needsScroll || offsetDelta < ScrollState.BottomScrollThreshold | ||
| self.isAtBottom = isAtBottom | ||
|
|
||
| //print("UPDATE: Bottom? \(isAtBottom) : delta: \(offsetDelta), on scroll - offset: \(Int(scrollOffset)), scrollHeight: \(Int(scrollViewHeight)), contentHeight: \(Int(contentHeight))") |
jonryser
approved these changes
Nov 28, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task : #86
Currently the behavior is that whenever text is generating, it forces the scroll of the chat window, preventing a user from scrolling up while text is generating. However, allowing the user to scroll is common behavior of most AI chat interfaces. This allows a user to scroll independent of text being generated.
TODO - verify this feels good a device.
(updated style based on Ian's quick feedback)
ai2-chat-scrolling-1.mov