-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration for open sourcing #88
Conversation
OLMoE.swift/README.md
Outdated
|
||
4. Select the project in the Project Navigator. | ||
1) In configurations ensure "Debug and Release" is set to use `release.xcconfig` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may actually want to refer to debug.xconfig
for debug / development builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that too. But it may create more initial complexity than needed for open sourcing. We can and other developers could, of course, refine the configuration to their needs. But perhaps a single file for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. The only think I mentioned was maybe we support a debug.xconfig
, or consider renaming release.xconfig merely to build.xconfig
. It feels strange and a bit non-standard for debug to point to something referred to as 'release'.
Yeah, I agree and like that better. I'll change it to |
Initially I could not build the app and got this message: To get it to build I had to "Enable Development Signing". Locally is working again but can we be sure this won't be a problem during release? |
@Stanley-Jovel - Could we connect on this? I'd like to see what you had to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme looks great
…o ready-4-opensource
Describe the changes
build.xcconfig
). This keeps the Allen Inst or GenUI values out of the repo.DEBUG
is configured to "Sign to Run Locally"Issue ticket number and link
#11
Checklist before requesting a review