Maintain contained objects when placed on stove #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, a pan with a potato in it placed on the stove will no longer logically contain the potato, even though it's clearly sitting there. The code, including the comment about why we use the stationary drop, is copied exactly from the `PlaceObject()`, where I observed it working fine for placing the pan with the potato in it onto the counter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, a pan with a potato in it placed on the stove will no longer logically contain the potato (i.e. the potato will be missing from
receptacleObjectIds), even though it's clearly still sitting there in the pan. The code, including the comment about why we use the stationary drop, is copied exactly from thePlaceObject(), where I observed it working fine for the case of placing the pan with the potato in it onto the counter.I don't understand all of the details of the system yet, so it's possible that the stationary drop was not the right action to take. I'm also unaware of how to write unit tests for this project, but if you can provide some guidance then I will be happy to contribute some. I did do manual testing, though, and the
receptacleObjectIdsproperty has been fixed for the case outlined above.