Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Enable multi-process training on CPU #4272

Merged
merged 6 commits into from
May 21, 2020
Merged

Enable multi-process training on CPU #4272

merged 6 commits into from
May 21, 2020

Conversation

dirkgr
Copy link
Member

@dirkgr dirkgr commented May 21, 2020

This is probably only useful during testing.

@dirkgr dirkgr self-assigned this May 21, 2020
@dirkgr dirkgr marked this pull request as ready for review May 21, 2020 19:09
@dirkgr dirkgr requested a review from epwalsh May 21, 2020 19:09
@dirkgr
Copy link
Member Author

dirkgr commented May 21, 2020

@epwalsh, can you review this? Especially the way the tests are configured?

@epwalsh
Copy link
Member

epwalsh commented May 21, 2020

Yeup! I’ll take a look right after lunch

Copy link
Member

@epwalsh epwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks like there are some multi-gpu tests in tests/training/trainer_test.py that might make sense to mark as @cpu_or_gpu as well?

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Evan Pete Walsh <epwalsh10@gmail.com>
@dirkgr
Copy link
Member Author

dirkgr commented May 21, 2020

LGTM! Looks like there are some multi-gpu tests in tests/training/trainer_test.py that might make sense to mark as @cpu_or_gpu as well?

There is only one, and it's about raising an error, so I want to leave that one alone.

@dirkgr dirkgr merged commit f27475a into master May 21, 2020
@dirkgr dirkgr deleted the MultiProcessCPU branch May 21, 2020 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants