Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Allow W&B anon mode #5110

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Allow W&B anon mode #5110

merged 2 commits into from
Apr 22, 2021

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Apr 9, 2021

WANDB_API_KEY no longer required (although still recommended).

If you don't provide this key, you may get prompted to choose what to do:

image

@epwalsh epwalsh requested a review from dirkgr April 9, 2021 20:54
@dirkgr
Copy link
Member

dirkgr commented Apr 9, 2021

... and if you don't have wandb installed at all, none of this happens, right?

@dirkgr
Copy link
Member

dirkgr commented Apr 9, 2021

@vanpelt, what do you think?

@epwalsh
Copy link
Member Author

epwalsh commented Apr 9, 2021

... and if you don't have wandb installed at all, none of this happens, right?

Currently W&B is listed as a dependency. Although I think we should make it an optional dependency (same for tensorboard). Regardless, this is a trainer callback and so is only used if it's listed in the config file. This PR doesn't address that feature.

@epwalsh
Copy link
Member Author

epwalsh commented Apr 9, 2021

What's not ideal about this is that you are prompted for input. If you were running this in a non-interactive environment (like Beaker batch) this wouldn't work.

@dirkgr
Copy link
Member

dirkgr commented Apr 9, 2021

Does it detect when it's not running on a terminal?

@dirkgr dirkgr enabled auto-merge (squash) April 22, 2021 21:31
@dirkgr dirkgr merged commit 6ec6459 into main Apr 22, 2021
@dirkgr dirkgr deleted the wandb-anon branch April 22, 2021 21:41
dirkgr pushed a commit that referenced this pull request May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants