Log batch metrics #5362
Log batch metrics #5362
Conversation
| if key.startswith("batch_"): | ||
| continue |
There was a problem hiding this comment.
Does this mean we don't log any metrics in metrics that start with batch_? Is that really what we want?
There was a problem hiding this comment.
I wanted to avoid creating "batch_batch_loss" and "batch_batch_reg_loss", and I generalized a little. It doesn't make a ton of sense to define a metric called batch_*, because all metrics that come from the model are also calculated per epoch.
There was a problem hiding this comment.
batch_size is one exception I can think of
There was a problem hiding this comment.
Since we already handle batch_loss and batch_reg_loss separately, how we just explicitly ignore those here?
There was a problem hiding this comment.
Yeah, I'll do that as soon ad I can get GitHub to talk to me again :-/
Fixes #5351.