Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Fix PairedPCABiasDirection #5396

Merged
merged 6 commits into from
Sep 17, 2021

Conversation

oskarvanderwal
Copy link
Contributor

Fixes #5395

Changes proposed in this pull request:

  • Added flag center=false to torch.pca_lowrank in PairedPCABiasDirection to avoid centring the difference vectors.
  • Adjusted bias_direction_test.py to facilitate new (correct) paired PCA bias direction.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@AkshitaB AkshitaB self-requested a review September 17, 2021 23:55
Copy link
Contributor

@AkshitaB AkshitaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oskarvanderwal Thank you for identifying and fixing this issue! PR looks good to me.

@AkshitaB AkshitaB merged commit 43fd982 into allenai:main Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PairedPCABiasDirection should not center difference vectors
2 participants