This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposed change impacts the behavior of⚠️
--overrides
in a potentially breaking wayOverview
Previously the final configuration params read from a file were simply taken as the union over the original params in the file and the params specified in
--overrides
. With this, you can now use--overrides
to completely replace any part of the original config.For example, passing
--overrides '{"model":{"type":"foo"}}'
will completely replace the "model" part of the original config. However, when you just want to change a single field in the JSON structure without removing / replacing adjacent fields, you can still use the "dot" syntax. For example,--overrides '{"model.num_layers":3}'
will only change thenum_layers
parameter to the "model" part of the config, leaving everything else unchanged.Why is this useful?
With the old behavior it is impossible to remove any fields from the a config via
--overrides
. This becomes an issue when, for example, you want to change the type of yourdataset_reader
ormodel
to a different type that takes completely different arguments.cc @yakazimir