This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
integrate cached_path #5418
Merged
integrate cached_path #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryant1410
reviewed
Oct 8, 2021
|
|
||
| from allennlp.common import file_utils | ||
| from allennlp.common.file_utils import ( | ||
| FileLock, |
There was a problem hiding this comment.
FileLock, _resource_to_filename, CacheFile, and _Meta should now come from cached_path, right?
There was a problem hiding this comment.
Well, yes.. sort of. In file_utils I imported all of those things from cached_path to make sure that if anyone was using these utilities directly from file_utils, this change wouldn't break anything for them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.