Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Add installation instructions through conda-forge #5498

Merged
merged 5 commits into from
Dec 9, 2021
Merged

Conversation

h-vetinari
Copy link
Contributor

After almost a year of operating the various feedstocks for the allennlp-ecosystem, I think it's justified to add the installation instructions for conda-forge also in the main repo.

I've allowed myself to place the conda install first, because (if only measured by number of lines and/or instructions), it is much easier than the installation through pip.

However, I'm happy to adapt this in any way necessary so that people here are happy with it.

Git messes up the diff quite a bit, so I've broken down the commits into more digestible pieces.

Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big fan! Thank you!

@dirkgr
Copy link
Member

dirkgr commented Dec 9, 2021

Does this work already with https://github.com/allenai/tango? Can we do it there too?

@h-vetinari
Copy link
Contributor Author

Does this work already with https://github.com/allenai/tango? Can we do it there too?

Tango is already available. :)

Happy to do it there too, but wanted to get some overall feedback first.

@h-vetinari
Copy link
Contributor Author

One more thought: generally, we'll be fast to release for conda-forge, but I opened a tracker for new dependencies on the feedstock to cut down on the lag where possible: conda-forge/allennlp-feedstock#32

@dirkgr dirkgr enabled auto-merge (squash) December 9, 2021 23:08
@dirkgr dirkgr merged commit dbcbcf1 into allenai:main Dec 9, 2021
@h-vetinari h-vetinari deleted the cf branch December 10, 2021 01:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants