Add support for actions and input fields #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some support for the following actions: * Selection * Text * Button/ Action To get the values from the actions and input fields some handlers were added. These will be called by windows and execute user supplied closures. Note that the closures are `Send` to avoid a future breaking change because of an update of the `windows`-crate.
Open
|
@allenbenz hey would really appreciate if you could give the reigns for the repo to another person. It could really speed up development, developer experience, and improve the overall ecosystem. Especially for Tauri developers since this is used by Tauri indirectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some support and examples for the following actions:
To get the values from the actions and input fields some handlers were added.
These will be called by windows and execute user supplied closures.
To avoid breaking changes
ToastWithHandlerswon't be integrated inToast.ToastWithHandlersrequires an ownedselfbecause the handler closure will be moved. Technically it may be possible to work around this with some shared ownership of the handler closures but this could be difficult.Should the crate get a new release so that users and other crates could use this soon?