Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to add scan topic (in filename) #191

Merged
merged 2 commits into from
Jun 23, 2020
Merged

option to add scan topic (in filename) #191

merged 2 commits into from
Jun 23, 2020

Conversation

thrillfall
Copy link
Contributor

@thrillfall thrillfall commented May 3, 2020

Description

This PR adds the option to set a "topic" (basically any string you provide) for every scan you make and puts that string into the filename.
If you enable the option in the settings there will be dialog after every scan asking to set a topic.

ons-topic-dialog

The idea is that i want to scan invoices/receipts and have all those scans searchable by filename. So if i have a receipt from book store "books haven" i'd scan that receipt and put "books haven" as topic. If i ever need to find that receipt i can just search all the scan files for the book store name.

This is the most basic and (hopefully) least invasive approach i could think off.
As a next increment i could imagine additionally having a predefined (but customizable by the user) list of document types like invoice, receipt, ticket, you name to enable users to add somewhat of a system to their scans

Fixes

it does not fix the issue #183 but tackles the first requirement (Allow assigning a name to each document directly after scanning.)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • ./gradlew checkstyle

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@allgood allgood merged commit 554b25e into allgood:master Jun 23, 2020
@allgood
Copy link
Owner

allgood commented Jun 23, 2020

This is great! It is a good feature while automatic tagging isn't implemented, and probably after, giving ability to have more tags.

I will look also on a way to save the topic on image metadata.

@allgood
Copy link
Owner

allgood commented Jul 4, 2020

@thrillfall , can you take a look at bug #199 ? I want to make a new release of open note scanner next week with this feature enabled.

Thank you!

@allgood
Copy link
Owner

allgood commented Jul 4, 2020

@thrillfall , bug report #200 is also related to this PR.

@thrillfall
Copy link
Contributor Author

I wont have time to look into it. Sorry. Please revert this and maybe i (or someone else) can do this properly in the future

@allgood
Copy link
Owner

allgood commented Jul 5, 2020

@thrillfall , no problem, I will not revert it! I will try to take a look if I can enhance it before the release

@allgood
Copy link
Owner

allgood commented Jul 11, 2020

@thrillfall , just fixed it on commit a3f2fb9 - your contribution will be on next release! Thank you!

@thrillfall
Copy link
Contributor Author

@thrillfall , just fixed it on commit a3f2fb9 - your contribution will be on next release! Thank you!

thank you for including and fixing this! looking forward to the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants