Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Unlock doesn't release connection #10

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

BradLugo
Copy link
Contributor

BREAKING CHANGE: Changes the Locker interface and requires the user
to call Close instead of Unlock to release the connection.

Closes #9

BREAKING CHANGE: Changes the Locker interface and requires the user
to call Close instead of Unlock to release the connection.
@BradLugo
Copy link
Contributor Author

This fix requires a major version bump. I'm happy to modify the solution to something that doesn't require one if anyone has suggestions.

Copy link
Owner

@allisson allisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BradLugo Thanks!

I'll prepare a 3.0.0 release ASAP 👍

@allisson allisson merged commit b4bcd2a into allisson:master Aug 1, 2022
@allisson
Copy link
Owner

allisson commented Aug 1, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document that Unlock leaves the Lock object unusable (because it calls l.conn.Close)
2 participants