Debugger

README.md

@@ -32,6 +32,7 @@ or with more configuration options:
 cargo build --release --package magenboy_sdl --features [optional_features]
 ```
 #### Optional features:
+* `dbg` - Enable debugger
 * `static-sdl` - will link statically to sdl2, On by default 
 * `sdl-resample` - Use the audio resampler from sdl2 library and a manual one I wrote
 * `push-audio` - Use a push methododlogy instead of pull for the delivery of the sound samples to sdl2

core/Cargo.toml

@@ -7,10 +7,13 @@ edition = "2018"
 
 [dependencies]
 log = "0.4"
+cfg-if = "1"
 
 [features]
+# default = ["dbg"]
 u16pixel = []
 apu = []
+dbg = []
 
 [dev-dependencies]
 criterion = "0.3"

core/src/cpu/gb_cpu.rs

@@ -1,5 +1,4 @@
-use crate::mmu::interrupts_handler::InterruptRequest;
-use crate::mmu::memory::Memory;
+use crate::mmu::{interrupts_handler::InterruptRequest, Memory};
 
 use super::register::Reg;
 use super::flag::Flag;
@@ -84,10 +83,10 @@ impl GbCpu {
     }
 
     pub fn inc_hl(&mut self){
-        *self.hl.value() = (*self.hl.value()).wrapping_add(1);
+        *self.hl.value_mut() = self.hl.value().wrapping_add(1);
     }
 
     pub fn dec_hl(&mut self){
-        *self.hl.value() = (*self.hl.value()).wrapping_sub(1);
+        *self.hl.value_mut() = self.hl.value().wrapping_sub(1);
     }
 }

core/src/cpu/opcode_runner.rs

@@ -1,4 +1,4 @@
-use crate::mmu::memory::Memory;
+use crate::mmu::Memory;
 use super::{
     gb_cpu::GbCpu, 
     opcodes::{

core/src/cpu/opcodes/arithmetic_16bit_instructions.rs

@@ -10,14 +10,14 @@ use super::opcodes_utils::{
 pub fn add_hl_rr(cpu:&mut GbCpu, opcode:u8)->u8{
     let reg = opcode >> 4;
     let reg = *get_arithmetic_16reg(cpu, reg);
-    let hl_value = *cpu.hl.value();
+    let hl_value = cpu.hl.value();
 
     let (value,overflow) = hl_value.overflowing_add(reg);
     cpu.set_by_value(Flag::Carry, overflow);
     cpu.set_by_value(Flag::HalfCarry, check_for_half_carry_third_nible_add(hl_value, reg));
     cpu.unset_flag(Flag::Subtraction);
 
-    *cpu.hl.value() = value;
+    *cpu.hl.value_mut() = value;
 
     // 2 cycles - 1 reading opcode, 1 internal operation
     return 1;