-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix account not being ready, better error handling, no nilp #38
Merged
xmariachi
merged 1 commit into
dev
from
diego/proto-2226-nil-pointer-being-passed-to-tx-registration
Aug 22, 2024
Merged
Fix account not being ready, better error handling, no nilp #38
xmariachi
merged 1 commit into
dev
from
diego/proto-2226-nil-pointer-being-passed-to-tx-registration
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedBird96
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
xmariachi
deleted the
diego/proto-2226-nil-pointer-being-passed-to-tx-registration
branch
August 22, 2024 15:32
xmariachi
added a commit
that referenced
this pull request
Sep 4, 2024
* add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- Co-authored-by: Kenny <pelusoken@gmail.com> * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> --------- Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions * allow devs pass in their existing wallets and don't override * fix startup edgecase * Diego/fix merge conflicts (main-dev) (#25) * add changelog + security (#9) * release v0.1.0 (#23) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- Co-authored-by: Kenny <pelusoken@gmail.com> * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> --------- Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Diego C <xmariachi@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> * remove usage of init.docker * fix readme conflicts * fix readme conflicts * use offchain-node as name --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> * Update config.example.json (#27) https://upshotworld.slack.com/archives/C06TUMEP3LM/p1723139422909399 By default we should have the worker and reputer run on the same port so that both work in the simplest path. Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Metrics (#28) * added metrics to offchain node * expose metrics port on 2112 * update readme * typo --------- Co-authored-by: Kenny <pelusoken@gmail.com> * update changelog + pr template * SubmitTx false - still sends tx (#31) * Do not force true on a value that is set by config * CHANGELOG updated * Update config.example.json (#32) Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * CDK config template file (#30) * adding CDK template file * whitespace * wrong var * adding new configs to template * all config values now configurable in cdk * Send data with retry bug (#33) * fix SendDataWithRetry bug * remove init.docker * update gas adjustment config (#34) * auto scrape metrics and push to telemetry * Fix covering nil pointer when params are not available (#37) * Fix account not being ready, better error handling, no nilp (#38) * PROTO-2220 Tidy go dependencies (#39) * PROTO-2220 Tidy go dependencies * Clean Changelog extra line * Fixes on forecasting (#40) * Fixes on forecasting * Add changelog, also refs for other PRs * rm how already being registered blocks stake update; ensure stake idempotency (#43) * docs: fix spelling issues (#36) * fix domain_config.go Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * fix factory_config.go Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * fix README.md Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> --------- Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * Diego/proto 2262 prevent nan infinity and other non numbers from being (#41) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 (#42) * Updates for chain version v0.4.0 * Updated changelog --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: RedBird96 <73715579+RedBird96@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
kpeluso
added a commit
that referenced
this pull request
Sep 4, 2024
* add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services * Update README.md * Update README.md --------- * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions * allow devs pass in their existing wallets and don't override * fix startup edgecase * Diego/fix merge conflicts (main-dev) (#25) * add changelog + security (#9) * release v0.1.0 (#23) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services * Update README.md * Update README.md --------- * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions --------- * remove usage of init.docker * fix readme conflicts * fix readme conflicts * use offchain-node as name --------- * Update config.example.json (#27) https://upshotworld.slack.com/archives/C06TUMEP3LM/p1723139422909399 By default we should have the worker and reputer run on the same port so that both work in the simplest path. * Metrics (#28) * added metrics to offchain node * expose metrics port on 2112 * update readme * typo --------- * update changelog + pr template * SubmitTx false - still sends tx (#31) * Do not force true on a value that is set by config * CHANGELOG updated * Update config.example.json (#32) * CDK config template file (#30) * adding CDK template file * whitespace * wrong var * adding new configs to template * all config values now configurable in cdk * Send data with retry bug (#33) * fix SendDataWithRetry bug * remove init.docker * update gas adjustment config (#34) * auto scrape metrics and push to telemetry * Fix covering nil pointer when params are not available (#37) * Fix account not being ready, better error handling, no nilp (#38) * PROTO-2220 Tidy go dependencies (#39) * PROTO-2220 Tidy go dependencies * Clean Changelog extra line * Fixes on forecasting (#40) * Fixes on forecasting * Add changelog, also refs for other PRs * rm how already being registered blocks stake update; ensure stake idempotency (#43) * docs: fix spelling issues (#36) * fix domain_config.go * fix factory_config.go * fix README.md --------- * Diego/proto 2262 prevent nan infinity and other non numbers from being (#41) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 (#42) * Updates for chain version v0.4.0 * Updated changelog --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: RedBird96 <73715579+RedBird96@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
xmariachi
added a commit
that referenced
this pull request
Sep 4, 2024
* add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- Co-authored-by: Kenny <pelusoken@gmail.com> * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> --------- Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions * allow devs pass in their existing wallets and don't override * fix startup edgecase * Diego/fix merge conflicts (main-dev) (#25) * add changelog + security (#9) * release v0.1.0 (#23) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- Co-authored-by: Kenny <pelusoken@gmail.com> * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> --------- Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Diego C <xmariachi@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> * remove usage of init.docker * fix readme conflicts * fix readme conflicts * use offchain-node as name --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> * Update config.example.json (#27) https://upshotworld.slack.com/archives/C06TUMEP3LM/p1723139422909399 By default we should have the worker and reputer run on the same port so that both work in the simplest path. Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Metrics (#28) * added metrics to offchain node * expose metrics port on 2112 * update readme * typo --------- Co-authored-by: Kenny <pelusoken@gmail.com> * update changelog + pr template * SubmitTx false - still sends tx (#31) * Do not force true on a value that is set by config * CHANGELOG updated * Update config.example.json (#32) Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * CDK config template file (#30) * adding CDK template file * whitespace * wrong var * adding new configs to template * all config values now configurable in cdk * Send data with retry bug (#33) * fix SendDataWithRetry bug * remove init.docker * update gas adjustment config (#34) * auto scrape metrics and push to telemetry * Fix covering nil pointer when params are not available (#37) * Fix account not being ready, better error handling, no nilp (#38) * PROTO-2220 Tidy go dependencies (#39) * PROTO-2220 Tidy go dependencies * Clean Changelog extra line * Fixes on forecasting (#40) * Fixes on forecasting * Add changelog, also refs for other PRs * rm how already being registered blocks stake update; ensure stake idempotency (#43) * docs: fix spelling issues (#36) * fix domain_config.go Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * fix factory_config.go Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * fix README.md Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> --------- Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * Diego/proto 2262 prevent nan infinity and other non numbers from being (#41) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 (#42) * Updates for chain version v0.4.0 * Updated changelog * Update go dependencies, increase loopSeconds on inferer (#49) * Merge dev -> main for release 0.3.0 (#48) (#51) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services * Update README.md * Update README.md --------- * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions * allow devs pass in their existing wallets and don't override * fix startup edgecase * Diego/fix merge conflicts (main-dev) (#25) * add changelog + security (#9) * release v0.1.0 (#23) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services * Update README.md * Update README.md --------- * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions --------- * remove usage of init.docker * fix readme conflicts * fix readme conflicts * use offchain-node as name --------- * Update config.example.json (#27) https://upshotworld.slack.com/archives/C06TUMEP3LM/p1723139422909399 By default we should have the worker and reputer run on the same port so that both work in the simplest path. * Metrics (#28) * added metrics to offchain node * expose metrics port on 2112 * update readme * typo --------- * update changelog + pr template * SubmitTx false - still sends tx (#31) * Do not force true on a value that is set by config * CHANGELOG updated * Update config.example.json (#32) * CDK config template file (#30) * adding CDK template file * whitespace * wrong var * adding new configs to template * all config values now configurable in cdk * Send data with retry bug (#33) * fix SendDataWithRetry bug * remove init.docker * update gas adjustment config (#34) * auto scrape metrics and push to telemetry * Fix covering nil pointer when params are not available (#37) * Fix account not being ready, better error handling, no nilp (#38) * PROTO-2220 Tidy go dependencies (#39) * PROTO-2220 Tidy go dependencies * Clean Changelog extra line * Fixes on forecasting (#40) * Fixes on forecasting * Add changelog, also refs for other PRs * rm how already being registered blocks stake update; ensure stake idempotency (#43) * docs: fix spelling issues (#36) * fix domain_config.go * fix factory_config.go * fix README.md --------- * Diego/proto 2262 prevent nan infinity and other non numbers from being (#41) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 (#42) * Updates for chain version v0.4.0 * Updated changelog --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: RedBird96 <73715579+RedBird96@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: RedBird96 <73715579+RedBird96@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com>
spooktheducks
added a commit
that referenced
this pull request
Sep 21, 2024
* add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- Co-authored-by: Kenny <pelusoken@gmail.com> * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> --------- Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions * allow devs pass in their existing wallets and don't override * fix startup edgecase * Diego/fix merge conflicts (main-dev) (#25) * add changelog + security (#9) * release v0.1.0 (#23) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- Co-authored-by: Kenny <pelusoken@gmail.com> * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Update README.md Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> --------- Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Diego C <xmariachi@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> * remove usage of init.docker * fix readme conflicts * fix readme conflicts * use offchain-node as name --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> * Update config.example.json (#27) https://upshotworld.slack.com/archives/C06TUMEP3LM/p1723139422909399 By default we should have the worker and reputer run on the same port so that both work in the simplest path. Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * Metrics (#28) * added metrics to offchain node * expose metrics port on 2112 * update readme * typo --------- Co-authored-by: Kenny <pelusoken@gmail.com> * update changelog + pr template * SubmitTx false - still sends tx (#31) * Do not force true on a value that is set by config * CHANGELOG updated * Update config.example.json (#32) Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> * CDK config template file (#30) * adding CDK template file * whitespace * wrong var * adding new configs to template * all config values now configurable in cdk * Send data with retry bug (#33) * fix SendDataWithRetry bug * remove init.docker * update gas adjustment config (#34) * auto scrape metrics and push to telemetry * Fix covering nil pointer when params are not available (#37) * Fix account not being ready, better error handling, no nilp (#38) * PROTO-2220 Tidy go dependencies (#39) * PROTO-2220 Tidy go dependencies * Clean Changelog extra line * Fixes on forecasting (#40) * Fixes on forecasting * Add changelog, also refs for other PRs * rm how already being registered blocks stake update; ensure stake idempotency (#43) * docs: fix spelling issues (#36) * fix domain_config.go Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * fix factory_config.go Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * fix README.md Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> --------- Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * Diego/proto 2262 prevent nan infinity and other non numbers from being (#41) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 (#42) * Updates for chain version v0.4.0 * Updated changelog * Update go dependencies, increase loopSeconds on inferer (#49) * Merge dev -> main for release 0.3.0 (#48) (#51) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services * Update README.md * Update README.md --------- * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions * allow devs pass in their existing wallets and don't override * fix startup edgecase * Diego/fix merge conflicts (main-dev) (#25) * add changelog + security (#9) * release v0.1.0 (#23) * add changelog + security * Deployment (#10) * add changelog + security (#9) * added dockerfile * fix bug on build * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * push to dockerhub instead * deployment done --------- * use internal network dns * Deployment (#13) * change the wkdir to /data * change the wkdir to / * fix typo * back to /node * deploy 2 reputer and workers for topic 1 * random * API Adapter with README ORA-2066 (#12) * API Adapter with README * move API adapter readme inside dir * Config file/env var + factory adapters + minor fixes * updating readme to tell you to copy the env file and fill it out before running docker-compose (#14) * readme changes (#15) * chore: fix typos README.md (#17) Hello, I found some typos in README.md "intentend" to "intended" "be use" to "be used" And there were also missing space in "InferenceEndpointis required if InferenceEntrypoint is defined.". This canged for "InferenceEndpoint is required if InferenceEntrypoint is defined." Hope this helps. * update dependencies, do not print conf (#18) * Cleanups (#16) * cleanups * efficient deployment updates * fix bug --------- * fix issues with docker-compose initialize * readme fix * forecast should return nodeValue * Update dependencies + reputer nonce fix (#19) * fix deprecated docker compose command * string interpolation * uniform backoff (#21) * uniform backoff * README update * Update and rename start.docker to init.docker (#22) * Update and rename start.docker to init.docker on devnet, when running the command: ``` chmod +x start.docker ./start.docker ``` the worker node won't register because it is not funded. The wallet for the worker node is being created and the node is attempting to register to the network in one go. However, for the user this will never work. What they will have to do is 1. run the command 2. kill the terminal 3. fund their wallet 4. rerun the chmod command The fix proposed is: 1. run init.docker to generate address and then you can get the address funded manually 2. run docker compose --build separately to start your services * Update README.md * Update README.md --------- * fix the conflicting account issues * add pull request template * correct the wkdir for source github actions --------- * remove usage of init.docker * fix readme conflicts * fix readme conflicts * use offchain-node as name --------- * Update config.example.json (#27) https://upshotworld.slack.com/archives/C06TUMEP3LM/p1723139422909399 By default we should have the worker and reputer run on the same port so that both work in the simplest path. * Metrics (#28) * added metrics to offchain node * expose metrics port on 2112 * update readme * typo --------- * update changelog + pr template * SubmitTx false - still sends tx (#31) * Do not force true on a value that is set by config * CHANGELOG updated * Update config.example.json (#32) * CDK config template file (#30) * adding CDK template file * whitespace * wrong var * adding new configs to template * all config values now configurable in cdk * Send data with retry bug (#33) * fix SendDataWithRetry bug * remove init.docker * update gas adjustment config (#34) * auto scrape metrics and push to telemetry * Fix covering nil pointer when params are not available (#37) * Fix account not being ready, better error handling, no nilp (#38) * PROTO-2220 Tidy go dependencies (#39) * PROTO-2220 Tidy go dependencies * Clean Changelog extra line * Fixes on forecasting (#40) * Fixes on forecasting * Add changelog, also refs for other PRs * rm how already being registered blocks stake update; ensure stake idempotency (#43) * docs: fix spelling issues (#36) * fix domain_config.go * fix factory_config.go * fix README.md --------- * Diego/proto 2262 prevent nan infinity and other non numbers from being (#41) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 (#42) * Updates for chain version v0.4.0 * Updated changelog --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: Kenny <pelusoken@gmail.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Kenny P <17100641+kpeluso@users.noreply.github.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: RedBird96 <73715579+RedBird96@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> * Diego/chain upgrade v0.4.0 fixes PROTO-2352 (#53) * Reputer: MSE, Protect vs NaN/Inf, unit test * Fixes on sanitize gt value for a Dec + remove Abs, strict err handling * Remove comments * Add Changelog * Updates for chain version v0.4.0 * Updated changelog * Update to v0.5.0 dependencies * Update deps + Bundle validation pre-sending + clean * better comment * Passive set: do not retry if score already found (#55) * Passive set: do not retry if score already found * CHANGELOG - rework and set 0.3.0 * Add CHANGELOG line for this PR * Update description in prometheus section (#54) Signed-off-by: Andrew <30905073+0ndrec@users.noreply.github.com> * improve logs (#56) * improve logs * add to changelog * Reduce severity of node nonce error (#57) * Reduce severity of node nonce error * add to changelog --------- Signed-off-by: osrm <90407222+osrm@users.noreply.github.com> Signed-off-by: kush-alloralabs <kush@alloralabs.xyz> Signed-off-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Signed-off-by: Andrew <30905073+0ndrec@users.noreply.github.com> Signed-off-by: Yung Spook <spooktheducks@protonmail.com> Co-authored-by: Tobi Okedeji <tobiokedeji@gmail.com> Co-authored-by: Diego C <xmariachi@gmail.com> Co-authored-by: Madison Williams <madisonjw@gmail.com> Co-authored-by: osrm <90407222+osrm@users.noreply.github.com> Co-authored-by: kush-alloralabs <kush@alloralabs.xyz> Co-authored-by: RedBird96 <73715579+RedBird96@users.noreply.github.com> Co-authored-by: Elias Rad <146735585+nnsW3@users.noreply.github.com> Co-authored-by: Andrew <30905073+0ndrec@users.noreply.github.com> Co-authored-by: Yung Spook <spooktheducks@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of Changes and their Description
PROTO-2226
Graceful error handling on configuration/registration errors.
Are these changes tested and documented?
Unreleased
section ofCHANGELOG.md
?