update comments (#521)

alloy-rs · Apr 12, 2024 · cc1c9a8 · cc1c9a8
1 parent ff0d155
commit cc1c9a8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/crates/rpc-types/src/eth/transaction/error.rs b/crates/rpc-types/src/eth/transaction/error.rs
@@ -34,7 +34,7 @@ pub enum ConversionError {
     /// Missing `to` field for EIP-4844 transaction.
     #[error("missing `to` field for EIP-4844 transaction")]
     MissingTo,
-    /// Missing `chainId` field for EIP-1559 transaction.
+    /// Missing `blobVersionedHashes` field for EIP-4844 transaction.
     #[error("missing `blobVersionedHashes` field for EIP-4844 transaction")]
     MissingBlobVersionedHashes,
 }
diff --git a/crates/rpc-types/src/eth/transaction/mod.rs b/crates/rpc-types/src/eth/transaction/mod.rs
@@ -105,8 +105,9 @@ pub struct Transaction {
     pub access_list: Option<AccessList>,
     /// EIP2718
     ///
-    /// Transaction type, Some(2) for EIP-1559 transaction,
-    /// Some(1) for AccessList transaction, None for Legacy
+    /// Transaction type,
+    /// Some(3) for EIP-4844 transaction, Some(2) for EIP-1559 transaction,
+    /// Some(1) for AccessList transaction, None or Some(0) for Legacy
     #[serde(
         default,
         rename = "type",