chore: fix some warnings

alloy-rs · Sep 20, 2024 · f6c8997 · f6c8997
1 parent 57dd4c5
commit f6c8997
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 9 deletions.
diff --git a/crates/node-bindings/src/nodes/geth.rs b/crates/node-bindings/src/nodes/geth.rs
@@ -648,9 +648,8 @@ impl Geth {
 // These tests should use a different datadir for each `geth` spawned.
 #[cfg(test)]
 mod tests {
-    use crate::utils::run_with_tempdir_sync;
-
     use super::*;
+    use crate::utils::run_with_tempdir_sync;
 
     #[test]
     fn port_0() {

diff --git a/crates/node-bindings/src/nodes/reth.rs b/crates/node-bindings/src/nodes/reth.rs
@@ -533,7 +533,7 @@ mod tests {
     use crate::utils::run_with_tempdir_sync;
 
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth() {
         run_with_tempdir_sync("reth-test-", |temp_dir_path| {
             let reth = Reth::new().data_dir(temp_dir_path).spawn();
@@ -543,7 +543,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth_sepolia() {
         run_with_tempdir_sync("reth-test-", |temp_dir_path| {
             let reth = Reth::new().chain_or_path("sepolia").data_dir(temp_dir_path).spawn();
@@ -553,7 +553,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth_dev() {
         run_with_tempdir_sync("reth-test-", |temp_dir_path| {
             let reth = Reth::new().dev().disable_discovery().data_dir(temp_dir_path).spawn();
@@ -563,7 +563,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth_dev_custom_genesis() {
         run_with_tempdir_sync("reth-test-", |temp_dir_path| {
             let reth = Reth::new()
@@ -578,7 +578,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth_dev_custom_blocktime() {
         run_with_tempdir_sync("reth-test-", |temp_dir_path| {
             let reth = Reth::new()
@@ -593,7 +593,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth_p2p_instances() {
         run_with_tempdir_sync("reth-test-", |temp_dir_path| {
             let reth = Reth::new().instance(100).data_dir(temp_dir_path).spawn();
@@ -611,7 +611,7 @@ mod tests {
     // Tests that occupy the same port are combined so they are ran sequentially, to prevent
     // flakiness.
     #[test]
-    #[cfg(not(windows))]
+    #[cfg_attr(windows, ignore)]
     fn can_launch_reth_custom_ports() {
         // Assert that all ports are default if no custom ports are set
         // and the instance is set to 0.

diff --git a/crates/provider/src/provider/trait.rs b/crates/provider/src/provider/trait.rs
@@ -1,4 +1,7 @@
 //! Ethereum JSON-RPC provider.
+
+#![allow(elided_named_lifetimes)]
+
 use crate::{
     heart::PendingTransactionError,
     utils::{self, Eip1559Estimation, EstimatorFunction},

diff --git a/crates/rpc-client/tests/it/main.rs b/crates/rpc-client/tests/it/main.rs
@@ -1,4 +1,5 @@
 #![allow(dead_code)]
+#![allow(missing_docs)]
 
 #[cfg(feature = "reqwest")]
 mod http;