Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Replace U64 and similar with primitive u64 #1026

Closed
DaniPopes opened this issue Jul 9, 2024 · 0 comments
Closed

[Feature] Replace U64 and similar with primitive u64 #1026

DaniPopes opened this issue Jul 9, 2024 · 0 comments
Assignees
@yash-atreya
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Member

Component

rpc

Describe the feature you would like

We're using ruint U64 due to its serde implementation being ethereum quantity, however its API is worse than using primitives and we shouldn't be relying on ruint to maintain full ethereum quantity support.

We should move away as much as possible by using primitive u64 and equivalents, and using alloy_serde::quantity as the serde implementation instead.

Additional context

No response
@DaniPopes DaniPopes added enhancement New feature or request good first issue Good for newcomers labels Jul 9, 2024
@yash-atreya yash-atreya mentioned this issue Jul 15, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-atreya yash-atreya

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yash-atreya @DaniPopes