Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace U64 with u64 #1057

Merged
merged 3 commits into from
Jul 15, 2024
Merged

refactor: replace U64 with u64 #1057

merged 3 commits into from
Jul 15, 2024

Conversation

yash-atreya
Copy link
Member

@yash-atreya yash-atreya commented Jul 15, 2024

Motivation

Ref #1026

Solution

Replace with primitve u64 and use alloy_serde::quantity for serde.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yash-atreya yash-atreya marked this pull request as draft July 15, 2024 12:40
@yash-atreya yash-atreya marked this pull request as ready for review July 15, 2024 12:46
@yash-atreya yash-atreya merged commit 008b99d into main Jul 15, 2024
22 checks passed
@yash-atreya yash-atreya deleted the yash/replace-U64 branch July 15, 2024 12:58
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* refactor: replace `U64` with `u64` in rpc-types-(eth|trace)

* replace `U64` in rpc-types-(eth|engine)

* use u128 in OptimismTransactionFields.mint
j75689 pushed a commit to bnb-chain/alloy that referenced this pull request Aug 1, 2024
* refactor: replace `U64` with `u64` in rpc-types-(eth|trace)

* replace `U64` in rpc-types-(eth|engine)

* use u128 in OptimismTransactionFields.mint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants