Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Evaluate correctness of BlockNumberOrTag versus BlockId usage in RPC methods #1134

Closed
zerosnacks opened this issue Aug 7, 2024 · 0 comments · Fixed by #1135
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zerosnacks
Copy link
Member

Component

rpc

What version of Alloy are you on?

No response

Operating System

macOS (Intel)

Describe the bug

According to the execution API documentation: https://ethereum.github.io/execution-apis/api-documentation/ it appears that some of the RPC methods support BlockId (the superset incl. block hashes) rather than BlockNumberOrTag (tag + block numbers).

One of them is

/// Gets the selected block [BlockNumberOrTag] receipts.
async fn get_block_receipts(
&self,
block: BlockNumberOrTag,
) -> TransportResult<Option<Vec<N::ReceiptResponse>>> {
self.client().request("eth_getBlockReceipts", (block,)).await
}
as flagged in this PR: foundry-rs/foundry#8623

Goal of this ticket would be to go through the RPC methods and evaluate + fix where we can use the BlockId superset over the BlockNumberOrTag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant