fix: use BlockId superset over BlockNumberOrTag where applicable
#1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debug` were not being tested
…et to investigate failure cases
zerosnacks
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
zerosnacks
commented
Aug 8, 2024
| @@ -1107,7 +1107,7 @@ mod tests { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "ws")] | |||
| #[cfg(all(feature = "ws", not(windows)))] | |||
zerosnacks
commented
Aug 8, 2024
Comment on lines
+33
to
+34
| # All features | ||
| - "--all-features" |
There was a problem hiding this comment.
Test cases in trace, debug including others were actually not being tested by the CI
I think opting for an --all-features CI job makes sense here as a general solution, solving issues that may arise on a case-by-case basis
zerosnacks
changed the title
BlockId superset over BlockNumberOrTagBlockId superset over BlockNumberOrTag where applicable
mattsse
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1134
Solution
BlockIdwhere implementedget_block_receiptsas raised ineth_getBlockReceiptsshould accept block hashes foundry-rs/foundry#8623blockfor consistency--all-featuresCI flag to make sure all features are actually tested,trace/debug(and presumably other) tests were not actually ran in the CI. Created [Bug] Investigate failingsubscribe_block_wsandsubscribe_ws_boxedtests on Windows #1136 to investigate failingsubscribe_block_wsandsubscribe_ws_boxedtests on Windows now requiring skipping.PR Checklist