Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Implement EOF create variant for alloy_rpc_types_trace::otterscan::OperationType #1288

Open
emhane opened this issue Sep 13, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@emhane
Copy link
Member

emhane commented Sep 13, 2024

Component

rpc

Describe the feature you would like

Implement EOF create for enum

/// Operation type enum for `InternalOperation` struct
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum OperationType {
/// Operation Transfer
OpTransfer = 0,
/// Operation Contract self destruct
OpSelfDestruct = 1,
/// Operation Create
OpCreate = 2,
/// Operation Create2
OpCreate2 = 3,
}

Additional context

No response

@DaniPopes
Copy link
Member

This is tied to https://github.com/otterscan/otterscan/blob/c7b81575985ed57c723b84b2b8c5ff6c6e8c5131/src/types.ts#L91-L103

@mattsse
Copy link
Member

mattsse commented Sep 14, 2024

yeah we can't go off spec just yet, so best to hold off here imo

@emhane emhane added the blocked This cannot move forward until something else changes label Sep 15, 2024
@emhane
Copy link
Member Author

emhane commented Sep 15, 2024

blocked by otterscan/otterscan#2457

@emhane emhane removed the blocked This cannot move forward until something else changes label Sep 21, 2024
@emhane emhane self-assigned this Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants