fix(rpc): return error instead of wrong operation type in otterscan API #10896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
the
A-dependencies
|
blocked by alloy-rs/alloy#1288 |
emhane
force-pushed
the
emhane/bump-deps
branch
from
088dbc2
to
dbfef33
Compare
DaniPopes
reviewed
Sep 13, 2024
|
Doesn't have to be blocked on it, I doubt otterscan will add a new variant for this since it's essentially the same as create |
emhane
force-pushed
the
emhane/bump-deps
branch
from
6067378
to
93a3ef1
Compare
emhane
removed
the
S-blocked
emhane
changed the title
cargo update
emhane
added
C-bug
emhane
changed the title
mattsse
reviewed
Sep 18, 2024
There was a problem hiding this comment.
I don't think this is useful because mostlikely the user doesn't care whether the create was done in eof or not, as far as otterscan is concerned this is also just a Create and we shouldn't fail, so mapping this to a regular create variant makes more sense here until there's a spec update for otterscan
|
cool then we can add the variant to the otterscan type in alloy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error instead of wrong operation type for EOFCREATE in otterscan API, until otterscan API has EOF support. Likely users will believe that there is smthg wrong with the node rather than RPC response if we return the wrong operation type.