Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add rpc types for wallet_ namespace #1420

Closed
mattsse opened this issue Oct 2, 2024 · 4 comments · Fixed by #1448
Closed

[Feature] Add rpc types for wallet_ namespace #1420

mattsse opened this issue Oct 2, 2024 · 4 comments · Fixed by #1448
Assignees
@nadtech-hub
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mattsse
Copy link
Member

mattsse commented Oct 2, 2024

Component

rpc

Describe the feature you would like

just like txpool,eth,trace these types should go into another rpc-types-wallet crate and should include rpc type bindings for various wallet_ endpoints

https://github.com/ethereum/ERCs/blob/01f41b608ae7e6cf7ef6369144b62b954dd63a1e/ERCS/erc-7715.md#wallet-managed-sessions

https://eips.ethereum.org/EIPS/eip-5792#wallet_sendcalls

Additional context

No response
@mattsse mattsse added enhancement New feature or request good first issue Good for newcomers labels Oct 2, 2024
@nadtech-hub
Copy link
Contributor

nadtech-hub commented Oct 4, 2024 •
edited
Loading

Do you mind if I do it?

@mattsse
Copy link
Member Author

mattsse commented Oct 5, 2024

please go for it

@mattsse
Copy link
Member Author

mattsse commented Oct 5, 2024

there's some wip here

https://github.com/paradigmxyz/alphanet/pull/129/files#diff-f4101dafa4b2873ece04cc3c059d373ddd9143026a68c62c8e9431e7d3eb5b3aR35 which you can take

@nadtech-hub
Copy link
Contributor

nadtech-hub commented Oct 7, 2024 •
edited
Loading

@mattsse Did you mean to add wallet_sendCalls related types? I implemented all types in both EIPs.

@nadtech-hub nadtech-hub mentioned this issue Oct 10, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadtech-hub nadtech-hub

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: wallet namespace types nadtech-hub/alloy
2 participants
@mattsse @nadtech-hub