feat: wallet namespace types #1448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadtech-hub
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
Signed-off-by: nadtech-hub <taberlick@gmail.com>
nadtech-hub
force-pushed
the
nadtech/wallet-namespace
branch
from
673909f
to
b93ff61
Compare
|
May I deliver other wallet types in separate pull requests? |
Signed-off-by: nadtech-hub <taberlick@gmail.com>
|
I didn't implement struct's getters / setters as long as their properties are made public |
mattsse
requested changes
Oct 11, 2024
Comment on lines
67
to
76
| /// Response type for RPC call. | ||
| /// | ||
| /// See [EIP-5792](https://eips.ethereum.org/EIPS/eip-5792#wallet_getcapabilities) | ||
| pub type GetCapabilitiesResult = HashMap<ChainId, HashMap<String, PermissionValue>>; | ||
|
|
||
| /// Response type of wallet_sendCalls | ||
| pub type SendCallsResult = String; | ||
|
|
||
| /// Request params of RPC call wallet_getCapabilities | ||
| pub type GetCapabilitiesParams = Vec<Address>; |
There was a problem hiding this comment.
can we use a copy of these types here
There was a problem hiding this comment.
please remove these aliases, these are not very useful
Signed-off-by: nadtech-hub <taberlick@gmail.com>
nadtech-hub
force-pushed
the
nadtech/wallet-namespace
branch
from
0316af9
to
e651a5c
Compare
mattsse
requested changes
Oct 14, 2024
crates/rpc-types-wallet/Cargo.toml
Outdated
| @@ -0,0 +1,29 @@ | |||
| [package] | |||
| name = "wallet-rpc-types" | |||
There was a problem hiding this comment.
Suggested change
| name = "wallet-rpc-types" | |
| name = "alloy-wallet-rpc-types" |
| pub calls: Vec<CallParams>, | ||
| /// Enabled permissions per chain | ||
| #[cfg_attr(feature = "serde", serde(default, skip_serializing_if = "Option::is_none"))] | ||
| pub capabilities: Option<HashMap<String, PermissionValue>> |
There was a problem hiding this comment.
I think we can just use serde value here and remove the permissionValue
Comment on lines
67
to
76
| /// Response type for RPC call. | ||
| /// | ||
| /// See [EIP-5792](https://eips.ethereum.org/EIPS/eip-5792#wallet_getcapabilities) | ||
| pub type GetCapabilitiesResult = HashMap<ChainId, HashMap<String, PermissionValue>>; | ||
|
|
||
| /// Response type of wallet_sendCalls | ||
| pub type SendCallsResult = String; | ||
|
|
||
| /// Request params of RPC call wallet_getCapabilities | ||
| pub type GetCapabilitiesParams = Vec<Address>; |
There was a problem hiding this comment.
please remove these aliases, these are not very useful
Signed-off-by: nadtech-hub <taberlick@gmail.com>
mattsse
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Should close #1420
Solution
Added response type of wallet_getCapabilities call.
PR Checklist