Replace assert_eq! with similar_asserts::assert_eq! #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xriazaka
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
approved these changes
Oct 3, 2024
mattsse
requested changes
Oct 3, 2024
mattsse
approved these changes
Oct 3, 2024
|
we def also want this in more tests in the rpc crates |
|
Sure will do that > we def also want this in more tests in the rpc crates |
0xriazaka
force-pushed
the
similar_asserts
branch
from
4110511
to
0368ad5
Compare
mattsse
previously requested changes
Oct 4, 2024
0xriazaka
force-pushed
the
similar_asserts
branch
from
0368ad5
to
cc36e25
Compare
|
resolved #1433 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
similar_asserts::assert_eq! highlights the exact differences between test subjects
Closes #1362
Solution
Replace assert_eq! with similar_asserts::assert_eq! on the "other" component
PR Checklist