Replace assert_eq! with similar_asserts::assert_eq! (serde json) #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xriazaka
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
3 tasks
DaniPopes
reviewed
Oct 5, 2024
crates/rpc-types-admin/src/admin.rs
Outdated
| @@ -283,7 +283,7 @@ mod tests { | |||
| }"#; | |||
| let peer_info: PeerInfo = serde_json::from_str(response).unwrap(); | |||
|
|
|||
| assert_eq!(peer_info.enode, "enode://bb37b7302f79e47c1226d6e3ccf0ef6d51146019efdcc1f6e861fd1c1a78d5e84e486225a6a8a503b93d5c50125ee980835c92bde7f7d12f074c16f4e439a578@127.0.0.1:60872"); | |||
| similar_asserts::assert_eq!(peer_info.enode, "enode://bb37b7302f79e47c1226d6e3ccf0ef6d51146019efdcc1f6e861fd1c1a78d5e84e486225a6a8a503b93d5c50125ee980835c92bde7f7d12f074c16f4e439a578@127.0.0.1:60872"); | |||
There was a problem hiding this comment.
It would be better if you imported it (use similar_asserts::assert_eq at the top of the test module) and kept the call sites the same
There was a problem hiding this comment.
using "use similar_asserts::assert_eq" at the test module level would affect all assert_eq! calls, not just those related to serde JSON
There was a problem hiding this comment.
I don't mind, this macro's output is always better @mattsse
There was a problem hiding this comment.
sure, wanna make this macro on every test module?
0xriazaka
force-pushed
the
similar_asserts_assert_eq!
branch
from
e749204
to
de2a133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
similar_asserts::assert_eq! highlights the exact differences between test subjects
Solution
Use similar_asserts for serde JSON comparison in rpc crates
Closes #1362
PR Checklist