Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Treat empty address filters as non matching if both are not empty #1470

Closed
mattsse opened this issue Oct 14, 2024 · 1 comment · Fixed by #1473
Closed

[Feature] Treat empty address filters as non matching if both are not empty #1470

mattsse opened this issue Oct 14, 2024 · 1 comment · Fixed by #1473
Assignees
Labels
enhancement New feature or request

Comments

@mattsse
Copy link
Member

mattsse commented Oct 14, 2024

Component

rpc

Describe the feature you would like

ref paradigmxyz/reth#11711

this will always be true if empty:

(self.from_addresses.matches(&from), self.to_addresses.matches(&to))

which wasn't the case pre 338b5b9

and is also not how https://github.com/erigontech/erigon/blob/72ab70be8b28964a8446e52b7a9975958c6726bf/turbo/jsonrpc/trace_filtering.go#L238-L289 behaves

Additional context

No response

@mattsse mattsse added the enhancement New feature or request label Oct 14, 2024
@jsvisa
Copy link
Contributor

jsvisa commented Oct 14, 2024

let me fix this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants