Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types/filter): treat empty filter address as non-matching #1473

Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix(types/filter): treat empty filter address as non-matching #1473

merged 5 commits into from
Oct 15, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 14, 2024

Motivation

fix #1470

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@jsvisa
fix(types/trace): rename matchs_all to is_empty
dd68c42 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
fix(types/trace): special cases for from/to address is empty
2586a61 
Signed-off-by: jsvisa <delweng@gmail.com>
@jsvisa
fix testcases
8e7dae5 
Signed-off-by: jsvisa <delweng@gmail.com>
mattsse
mattsse approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, tysm.

pending pedantic clippy

crates/rpc-types-trace/src/filter.rs Show resolved Hide resolved
@jsvisa
Merge branch 'main' into trace-filter-match
d3cdd07
@jsvisa
clippy
cc6acbc 
Signed-off-by: jsvisa <delweng@gmail.com>
@mattsse mattsse merged commit f37ac30 into alloy-rs:main Oct 15, 2024
26 checks passed
@jsvisa jsvisa deleted the trace-filter-match branch October 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Treat empty address filters as non matching if both are not empty
2 participants
@jsvisa @mattsse