Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable default-tls for alloy-provider/reqwest feature #483

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Apr 8, 2024

Motivation

Currently it's not possible to connect to https endpoint via on_http with default feature set

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@@ -55,6 +55,7 @@ reqwest = [
"dep:url",
"dep:alloy-transport-http",
"alloy-rpc-client/reqwest",
"alloy-transport-http/reqwest-default-tls",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will enable native tls, openssl by default now?

I want to avoid this because then this will now always enable default-tls for reqwest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to leave this up to the user we'd need to duplicate the features, I assume:

reqwest-default-tls = ["reqwest?/default-tls"]
reqwest-native-tls = ["reqwest?/native-tls"]
reqwest-rustls-tls = ["reqwest?/rustls-tls"]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should expose those in alloy-provider but enable default-tls by default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should expose those in alloy-provider

yes

but enable default-tls by default?

since reqwest enables this by default as well, I think that'd be reasonable.
but tls must be a separate feature, so default is = ["reqwest", "reqwest-default-ts"]

@klkvr klkvr requested a review from mattsse April 9, 2024 08:14
Copy link
Contributor

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @mattsse

@mattsse mattsse merged commit 2439614 into alloy-rs:main Apr 9, 2024
18 checks passed
klkvr added a commit to klkvr/alloy that referenced this pull request Apr 11, 2024
* enable default-tls for alloy-provider/reqwest feature

* update features
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* enable default-tls for alloy-provider/reqwest feature

* update features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants