Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable default-tls for alloy-provider/reqwest feature #483

Merged
merged 3 commits into from
Apr 9, 2024
Merged

enable default-tls for alloy-provider/reqwest feature #483

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cf09f1
enable default-tls for alloy-provider/reqwest feature
klkvr Apr 8, 2024
4f0c249
update features
klkvr Apr 9, 2024
5c5ca60
Merge branch 'main' into klkvr/enable-default-tls
klkvr Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/provider/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ reqwest = [
"dep:url",
"dep:alloy-transport-http",
"alloy-rpc-client/reqwest",
"alloy-transport-http/reqwest-default-tls",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will enable native tls, openssl by default now?

I want to avoid this because then this will now always enable default-tls for reqwest

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in order to leave this up to the user we'd need to duplicate the features, I assume:

alloy/crates/transport-http/Cargo.toml

Lines 40 to 42 in 6cc0af7

reqwest-default-tls = ["reqwest?/default-tls"]
reqwest-native-tls = ["reqwest?/native-tls"]
reqwest-rustls-tls = ["reqwest?/rustls-tls"]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should expose those in alloy-provider but enable default-tls by default?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we should expose those in alloy-provider

yes

but enable default-tls by default?

since reqwest enables this by default as well, I think that'd be reasonable.
but tls must be a separate feature, so default is = ["reqwest", "reqwest-default-ts"]

]
hyper = ["dep:alloy-transport-http", "dep:url", "alloy-rpc-client/hyper"]
ws = ["pubsub", "alloy-rpc-client/ws", "alloy-transport-ws"]
Expand Down
Loading