Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider): uncle methods for block hash #587

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix(provider): uncle methods for block hash #587

merged 2 commits into from
Apr 19, 2024

Conversation

yash-atreya
Copy link
Member

Motivation

get_uncle and get_uncle_count failed when BlockId::Hash was passed as the tag as the RpcBlockHash was being passed to the params directly instead of only the actual block_hash.

Solution

Pass actual block_hash and not the type.
Also, changed idx: U64 -> u64.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya @Evalir
doc nits
23776b6 
Co-authored-by: evalir <hi@enriqueortiz.dev>
@mattsse mattsse merged commit 31846e7 into alloy-rs:main Apr 19, 2024
18 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@yash-atreya @Evalir
fix(provider): uncle methods for block hash (alloy-rs#587)
26e9d47 
* fix(provider): uncle methods for block hash

* doc nits

Co-authored-by: evalir <hi@enriqueortiz.dev>

---------

Co-authored-by: evalir <hi@enriqueortiz.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir left review comments

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yash-atreya @mattsse @Evalir