Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): uncle methods for block hash #587

Merged
merged 2 commits into from
Apr 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/provider/src/provider.rs
Original file line number Diff line number Diff line change
Expand Up @@ -813,10 +813,12 @@ pub trait Provider<T: Transport + Clone = BoxTransport, N: Network = Ethereum>:
}

/// Gets an uncle block through the tag [BlockId] and index [U64].
yash-atreya marked this conversation as resolved.
Show resolved Hide resolved
async fn get_uncle(&self, tag: BlockId, idx: U64) -> TransportResult<Option<Block>> {
async fn get_uncle(&self, tag: BlockId, idx: u64) -> TransportResult<Option<Block>> {
match tag {
BlockId::Hash(hash) => {
self.client().request("eth_getUncleByBlockHashAndIndex", (hash, idx)).await
self.client()
.request("eth_getUncleByBlockHashAndIndex", (hash.block_hash, idx))
.await
}
BlockId::Number(number) => {
self.client().request("eth_getUncleByBlockNumberAndIndex", (number, idx)).await
Expand All @@ -829,7 +831,7 @@ pub trait Provider<T: Transport + Clone = BoxTransport, N: Network = Ethereum>:
match tag {
BlockId::Hash(hash) => self
.client()
.request("eth_getUncleCountByBlockHash", (hash,))
.request("eth_getUncleCountByBlockHash", (hash.block_hash,))
.await
.map(|count: U64| count.to::<u64>()),
BlockId::Number(number) => self
Expand Down
Loading