Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EngineApi extension trait #676

Merged
merged 4 commits into from
May 6, 2024
Merged

feat: add EngineApi extension trait #676

merged 4 commits into from
May 6, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented May 3, 2024

Closes #658

onbjerg
onbjerg requested changes May 3, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing https://github.com/ethereum/execution-apis/blob/main/src/engine/identification.md

@onbjerg onbjerg added the enhancement New feature or request label May 3, 2024
mattsse
mattsse requested changes May 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, smol nit

crates/provider/Cargo.toml Outdated Show resolved Hide resolved
crates/provider/src/ext/engine.rs Outdated Show resolved Hide resolved
onbjerg
onbjerg requested changes May 5, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

crates/provider/src/ext/engine.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes requested review from mattsse and onbjerg May 6, 2024 20:28
@mattsse mattsse merged commit 0d77f1e into alloy-rs:main May 6, 2024
24 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@leruaa
feat: add EngineApi extension trait (alloy-rs#676)
987cb7c 
* feat: add `EngineApi` extension trait

* feat: add get_client_version_v1()

* nit: rename `engine` feature

* nit: update get_client_version_v1() doc
@leruaa leruaa deleted the engine_ext_trait branch October 10, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add engine api extension
3 participants
@leruaa @onbjerg @mattsse