Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename DepositReceipt to DepositRequest #693

Merged
merged 1 commit into from
May 6, 2024

Conversation

onbjerg
Copy link
Member

@onbjerg onbjerg commented May 6, 2024

Motivation

Similar to #672, EIP-6110 has been changed to work with EIP-7685, which also included changes to the engine API spec, renaming deposit receipts to deposit requests.

Solution

  • Rename DepositReceipt to DepositRequest
  • Re-export DepositRequest as DepositRequestV1 in line with the engine API spec

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@onbjerg onbjerg added the debt Tech debt which needs to be addressed label May 6, 2024
@onbjerg onbjerg merged commit 35cbf35 into main May 6, 2024
24 checks passed
@onbjerg onbjerg deleted the onbjerg/eip6110-requests branch May 6, 2024 11:04
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Tech debt which needs to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants