-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider) : introduction to eth_sendRawTransactionConditional RPC endpoint type #1009
feat(provider) : introduction to eth_sendRawTransactionConditional RPC endpoint type #1009
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to limit this pr to the rpc type first, need to think about how to integrate this in the provider API
thanks for your review, does it look better for you ? |
/// Expected storage root hash of the account. | ||
StorageRoot(B256), | ||
/// Explicit storage slots and their expected values. | ||
Slots(HashMap<U256, B256>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm also not sure if this should be Slots(HashMap<B256, B256>), or Slots(HashMap<U256, B256>),
Hey @DoTheBestToGetTheBest , this is the implementation in Didn't get merged, but it's working since it's used in production in Silius (account abstraction bundler) |
ty, currently in this pr we just want to add the type |
@mattsse beffore i start to work on eth_simulateV1 , please take a look on this so we can done this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't hurt
…C endpoint type (alloy-rs#1009) * Update request.rs * Update trait.rs * clippy * Update trait.rs * Update trait.rs * added reference and camelCase serde * Update request.rs * Update lib.rs * Create eip4337.rs * Update eip4337.rs * fix serde * reorder --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
reference to the implementation : https://notes.ethereum.org/@yoav/SkaX2lS9j#
this method allows for the conditional processing of transactions based on predefined network states