Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider) : introduction to eth_sendRawTransactionConditional RPC endpoint type #1009

Merged
merged 13 commits into from
Jul 16, 2024

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

@DoTheBestToGetTheBest DoTheBestToGetTheBest commented Jul 3, 2024

reference to the implementation : https://notes.ethereum.org/@yoav/SkaX2lS9j#

this method allows for the conditional processing of transactions based on predefined network states

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to limit this pr to the rpc type first, need to think about how to integrate this in the provider API

@DoTheBestToGetTheBest
Copy link
Contributor Author

I'd like to limit this pr to the rpc type first, need to think about how to integrate this in the provider API

thanks for your review, does it look better for you ?

@DoTheBestToGetTheBest DoTheBestToGetTheBest changed the title feat(provider) : introduction to eth_sendRawTransactionConditional RPC endpoint feat(provider) : introduction to eth_sendRawTransactionConditional RPC endpoint type Jul 4, 2024
crates/rpc-types-eth/src/transaction/request.rs Outdated Show resolved Hide resolved
crates/rpc-types-eth/src/transaction/request.rs Outdated Show resolved Hide resolved
crates/rpc-types-eth/src/transaction/request.rs Outdated Show resolved Hide resolved
/// Expected storage root hash of the account.
StorageRoot(B256),
/// Explicit storage slots and their expected values.
Slots(HashMap<U256, B256>),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm also not sure if this should be Slots(HashMap<B256, B256>), or Slots(HashMap<U256, B256>),

@Vid201
Copy link
Contributor

Vid201 commented Jul 5, 2024

Hey @DoTheBestToGetTheBest , this is the implementation in ethers-rs : gakonst/ethers-rs#2595

Didn't get merged, but it's working since it's used in production in Silius (account abstraction bundler)

@DoTheBestToGetTheBest
Copy link
Contributor Author

Hey @DoTheBestToGetTheBest , this is the implementation in ethers-rs : gakonst/ethers-rs#2595

Didn't get merged, but it's working since it's used in production in Silius (account abstraction bundler)

ty, currently in this pr we just want to add the type

@DoTheBestToGetTheBest
Copy link
Contributor Author

@mattsse beffore i start to work on eth_simulateV1 , please take a look on this so we can done this

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't hurt

@mattsse mattsse merged commit 423a4c5 into alloy-rs:main Jul 16, 2024
22 checks passed
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
…C endpoint type (alloy-rs#1009)

* Update request.rs

* Update trait.rs

* clippy

* Update trait.rs

* Update trait.rs

* added reference and camelCase serde

* Update request.rs

* Update lib.rs

* Create eip4337.rs

* Update eip4337.rs

* fix serde

* reorder

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants