-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate valid signed auth signatures #1041
Merged
mattsse
merged 2 commits into
alloy-rs:main
from
Rjected:dan/arbitrary-random-signature
Jul 12, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -174,21 +174,21 @@ impl Deref for SignedAuthorization { | |
} | ||
} | ||
|
||
#[cfg(any(test, feature = "arbitrary"))] | ||
#[cfg(all(any(test, feature = "arbitrary"), feature = "k256"))] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could also make this work without the k256 feature but not useful imo |
||
impl<'a> arbitrary::Arbitrary<'a> for SignedAuthorization { | ||
fn arbitrary(u: &mut arbitrary::Unstructured<'a>) -> arbitrary::Result<Self> { | ||
use alloy_primitives::{b256, Parity}; | ||
use k256::ecdsa::{signature::hazmat::PrehashSigner, SigningKey}; | ||
let key_bytes = u.arbitrary::<[u8; 32]>()?; | ||
let signing_key = SigningKey::from_bytes(&key_bytes.into()) | ||
.map_err(|_| arbitrary::Error::IncorrectFormat)?; | ||
|
||
let inner = u.arbitrary::<Authorization>()?; | ||
let parity = u.arbitrary::<Parity>()?; | ||
let signature_hash = inner.signature_hash(); | ||
|
||
// TODO: find an easy way to generate random signatures | ||
let signature = Signature::from_rs_and_parity( | ||
b256!("c569c92f176a3be1a6352dd5005bfc751dcb32f57623dd2a23693e64bf4447b0").into(), | ||
b256!("1a891b566d369e79b7a66eecab1e008831e22daa15f91a0a0cf4f9f28f47ee05").into(), | ||
parity, | ||
) | ||
.map_err(|_| arbitrary::Error::IncorrectFormat)?; | ||
let (recoverable_sig, recovery_id) = | ||
signing_key.sign_prehash(signature_hash.as_ref()).unwrap(); | ||
let signature = Signature::from_signature_and_parity(recoverable_sig, recovery_id) | ||
.map_err(|_| arbitrary::Error::IncorrectFormat)?; | ||
|
||
Ok(Self { inner, signature }) | ||
} | ||
|
@@ -358,6 +358,7 @@ mod tests { | |
assert_eq!(decoded, auth); | ||
} | ||
|
||
#[cfg(feature = "k256")] | ||
#[test] | ||
fn test_arbitrary_auth() { | ||
let mut unstructured = arbitrary::Unstructured::new(b"unstructured auth"); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine because if if the feature is enabled on alloy-primitives this dep is already part of the dep tree