Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: alloy-consensus should use alloy_primitives::Sealable #1072

Merged
merged 2 commits into from
Jul 18, 2024
Merged

bug: alloy-consensus should use alloy_primitives::Sealable #1072

merged 2 commits into from
Jul 18, 2024

Conversation

zerosnacks
Copy link
Member

@zerosnacks zerosnacks commented Jul 18, 2024 •
edited
Loading

Motivation

Closes #1071

Solution

  • Re-exports Sealed and Sealable in the alloy-consensus crate to keep the export available

Breaking changes:

  • hash -> hash_slow (inherits the change in naming from alloy-primitives)
  • alloy-core does not implement the alias hash of seal, this can be added if desired in alloy-core
    /// Get the hash (alias for [`Self::seal`]).
    #[inline(always)]
    pub const fn hash(&self) -> B256 {
        self.seal()
    }

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@mattsse mattsse merged commit 067cc46 into main Jul 18, 2024
22 checks passed
@mattsse mattsse deleted the zerosnacks/consolidate-sealed branch July 18, 2024 16:03
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
@zerosnacks
bug: alloy-consensus should use alloy_primitives::Sealable (alloy…
7d2226f 
…-rs#1072)

* use Sealable and Sealed from alloy-primitives

* fix path in docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@Evalir Evalir Awaiting requested review from Evalir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] alloy-consensus should use alloy_primitives::Sealable
2 participants
@zerosnacks @mattsse