-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eip): make 7702 auth recovery fallible #1082
feat(eip): make 7702 auth recovery fallible #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, some suggestions
ty for your review boss, updated the changes (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last pedantic nits
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@mattsse thank you for your review ! made all changes you requested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
ty! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty
* ake 7702 auth recovery fallible * Update auth_list.rs * Update auth_list.rs * clippy * clippy * Update auth_list.rs * Update crates/eips/src/eip7702/auth_list.rs Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * Update auth_list.rs * Update crates/eips/src/eip7702/auth_list.rs Co-authored-by: Oliver <onbjerg@users.noreply.github.com> * Update crates/eips/src/eip7702/auth_list.rs Co-authored-by: Oliver <onbjerg@users.noreply.github.com> * chore: add is fns --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> Co-authored-by: Oliver <onbjerg@users.noreply.github.com>
closes #1068