Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add call_many #1085

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

as mentionned here #1074 call_many is not implemented

loocapro and others added 7 commits July 19, 2024 14:26
* added stages detail

* boxed enum

* from hashmap to vec with helper type

* serde alias and renames and dos

* Update crates/rpc-types-eth/src/syncing.rs

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* Update crates/rpc-types-eth/src/syncing.rs

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>

* property to pub

---------

Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
…y-rs#1083)

consensus: add From<ConsolidationRequest> for Request
@0xlosh
Copy link

0xlosh commented Jul 21, 2024

call_many should either take a Vec<TransactionRequest> or a Bundle, idk which one the alloy devs want to use, reth wants a Bundle

@DoTheBestToGetTheBest
Copy link
Contributor Author

call_many should either take a Vec<TransactionRequest> or a Bundle, idk which one the alloy devs want to use, reth wants a Bundle

you're right, thank you!

@zerosnacks zerosnacks changed the base branch from main to zerosnacks/fix-all-many-methods-rpc July 22, 2024 12:02
@zerosnacks
Copy link
Member

Thanks! Merging into zerosnacks/fix-all-many-methods-rpc to be included

@zerosnacks zerosnacks merged commit 8c45751 into alloy-rs:zerosnacks/fix-all-many-methods-rpc Jul 22, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants