feat(rpc/trace): filter matches with trace #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
This reverts commit 7f4ca13. Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
jsvisa
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
Evalir
as code owners
mattsse
requested changes
Jul 23, 2024
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Signed-off-by: jsvisa <delweng@gmail.com>
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* feat(trace): filter with TransactionTrace Signed-off-by: jsvisa <delweng@gmail.com> * wip: add test case Signed-off-by: jsvisa <delweng@gmail.com> * Revert "wip: add test case" This reverts commit 7f4ca13. Signed-off-by: jsvisa <delweng@gmail.com> * add test case Signed-off-by: jsvisa <delweng@gmail.com> * Update crates/rpc-types-trace/src/filter.rs Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * add more docs Signed-off-by: jsvisa <delweng@gmail.com> --------- Signed-off-by: jsvisa <delweng@gmail.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Filter the trace with trace {action,result}'s address, not by tx's {from, to}_address, inspired by https://github.com/openethereum/openethereum/blob/6c2d392d867b058ff867c4373e40850ca3f96969/crates/ethcore/src/trace/types/filter.rs#L95-L131 and https://github.com/ledgerwatch/erigon/blob/72ab70be8b28964a8446e52b7a9975958c6726bf/turbo/jsonrpc/trace_filtering.go#L238-L289
Solution
PR Checklist