-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Reth node bindings #1092
Conversation
@mattsse I'm running into some issues with To run the relevant test: FYI: because |
Github workflow for installing Geth and Reth binary is now fixed, cancelled the last workflow because the test doesn't end. |
[crates\node-bindings\src\nodes\reth.rs:369:13] &line = "2024-09-04T12:39:10.637528Z INFO reth::cli: Opening database path=\"C:\\\\Users\\\\RUNNER~1\\\\AppData\\\\Local\\\\Temp\\\\.tmp4XoSee\\\\db\"\n" [crates\node-bindings\src\nodes\reth.rs:369:13] &line = "2024-09-04T12:39:10.731699Z ERROR reth::cli: shutting down due to error\n" Error: failed to open the database: environment or database is not compatible with the requested operation or flags (-30784) Location: /project/crates/storage/db/src/mdbx.rs:28:8
Motivation
Closes #1062
Solution
Adds
reth
node bindings andreth
to the Github workflow for tests.The
reth
binary appears to be incompatible with the Windows CI:For now I've disabled the
reth
binding tests for Windows.PR Checklist