Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): Make Deserialize impl for FilterChanges generic over transaction #1118

Merged
merged 1 commit into from
Aug 1, 2024
Merged

chore(rpc): Make Deserialize impl for FilterChanges generic over transaction #1118

merged 1 commit into from
Aug 1, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Aug 1, 2024

Motivation

Make it possible to use non-default FilterChanges in reth RPC

Solution

Make Deserialize impl for FilterChanges generic over transaction

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@emhane emhane mentioned this pull request Aug 1, 2024
Merged
@mattsse mattsse merged commit a011cc5 into alloy-rs:main Aug 1, 2024
22 checks passed
@emhane emhane deleted the emhane/generic-deserialize-filter-changes branch August 2, 2024 16:10
@alloy-rs alloy-rs deleted a comment from harunfox72s Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emhane @mattsse