Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add authorization list to TransactionRequest #1125

Merged
merged 3 commits into from
Aug 5, 2024
Merged

feat: add authorization list to TransactionRequest #1125

merged 3 commits into from
Aug 5, 2024

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

closes #1122

onbjerg
onbjerg previously requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@onbjerg onbjerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct, an authorization list is a Vec<SignedAuthorization>, so this should be Option<Vec<SignedAuthorization>>.

@onbjerg onbjerg added the enhancement New feature or request label Aug 5, 2024
@DoTheBestToGetTheBest
Copy link
Contributor Author

this is not correct, an authorization list is a Vec<SignedAuthorization>, so this should be Option<Vec<SignedAuthorization>>.

make sens, ty for the review.

@mattsse mattsse merged commit 35e170d into alloy-rs:main Aug 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add authorization list to TransactionRequest
3 participants
@DoTheBestToGetTheBest @onbjerg @mattsse