Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use server_id when unsubscribing #1182

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: use server_id when unsubscribing #1182

merged 1 commit into from
Aug 23, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Aug 23, 2024

Motivation

ref https://t.me/ethers_rs/40198

Solution

Uses server_id when sending eth_unsubscribe request. Also updated all local_ids to use B256 everywhere to avoid unneccesary conversions

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@klkvr klkvr merged commit 974684b into main Aug 23, 2024
26 checks passed
@klkvr klkvr deleted the klkvr/fix-unsubscribe branch August 23, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse