Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: value of TxEip1559.ty #1210

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: value of TxEip1559.ty #1210

merged 1 commit into from
Aug 28, 2024

Conversation

bbjubjub2494
Copy link
Contributor

Motivation

TxEip1559::ty() returns a value indicating EIP-2930 transactions without EIP-1559 features. This is not correct.

Solution

Change the value

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! ty

@onbjerg onbjerg added the bug Something isn't working label Aug 28, 2024
@onbjerg onbjerg merged commit e30d510 into alloy-rs:main Aug 28, 2024
26 checks passed
@bbjubjub2494 bbjubjub2494 deleted the txeip1559ty branch August 29, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants