Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc-types-engine): no-std support #1233

Closed
wants to merge 10 commits into from
Closed

feat(rpc-types-engine): no-std support #1233

wants to merge 10 commits into from

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Sep 4, 2024 •
edited
Loading

Description

Note

Blocked by #1252

Adds no_std for the alloy-rpc-types-engine crate.

mattsse
mattsse requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also add this crate to

https://github.com/alloy-rs/op-alloy/blob/bd669da1ea0239411b317d81e30a0477aabb0808/scripts/check_no_std.sh#L4-L5

so we check in ci

crates/rpc-types-engine/src/lib.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/lib.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/Cargo.toml Outdated Show resolved Hide resolved
@refcell refcell mentioned this pull request Sep 9, 2024
Closed
mattsse
mattsse requested changes Sep 9, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

crates/rpc-types-engine/src/payload.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/payload.rs Outdated Show resolved Hide resolved
crates/rpc-types-engine/src/payload.rs Show resolved Hide resolved
crates/rpc-types-engine/src/forkchoice.rs Show resolved Hide resolved
@refcell refcell requested a review from mattsse September 9, 2024 18:48
@refcell
Copy link
Contributor Author

refcell commented Sep 9, 2024

This is failing no_std because alloy-rpc-types-eth is not no_std compatible yet (see: #1252)

@refcell refcell mentioned this pull request Sep 10, 2024
Merged
@refcell
Copy link
Contributor Author

refcell commented Sep 10, 2024

Replaced with #1268

@refcell refcell closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@emhane emhane Awaiting requested review from emhane

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @mattsse