consensus: add Receipts struct
#1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
reviewed
Sep 7, 2024
There was a problem hiding this comment.
the reth receipts type is very bad because the option was due to contract level pruning.
I'd prefer if we could remove the Option entirely, I assume we can do this if we change how we prune during pipeline execution, or use two types one non optional and one optional for pruned receipts
|
@mattsse Nice bump here, can we merge or any blocker? |
mattsse
requested changes
Sep 25, 2024
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
@mattsse done |
mattsse
approved these changes
Sep 25, 2024
lwedge99
pushed a commit
to sentioxyz/alloy
that referenced
this pull request
Oct 8, 2024
* consensus: add Receipts struct * fix cfg * fix comments * fix cargo file * fix imports * fix imports * Update crates/consensus/src/receipt/receipts.rs Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de> * fix nit --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related paradigmxyz/reth#7238