feat: Add iterator to BlobTransactionSidecar #1256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoTheBestToGetTheBest
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg,
prestwich and
emhane
as code owners
mattsse
requested changes
Sep 9, 2024
|
hey matts thanks for the reivew, made all changes you requested! |
mattsse
requested changes
Sep 12, 2024
Comment on lines
+395
to
+403
| #[cfg(feature = "serde")] | ||
| fn parse_u64_string<'de, T, D>(de: D) -> Result<T, D::Error> | ||
| where | ||
| D: serde::Deserializer<'de>, | ||
| T: FromStr, | ||
| <T as FromStr>::Err: core::fmt::Display, | ||
| { | ||
| String::deserialize(de)?.parse().map_err(serde::de::Error::custom) | ||
| } |
There was a problem hiding this comment.
this is just alloy-serde::quantity
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
Comment on lines
+52
to
+64
| impl BlobTransactionSidecar { | ||
| /// Creates an iterator | ||
| pub fn iter(&self) -> impl Iterator<Item = BlobTransactionSidecarItem> + '_ { | ||
| self.blobs.iter().zip(&self.commitments).zip(&self.proofs).enumerate().map( | ||
| |(index, ((blob, commitment), proof))| BlobTransactionSidecarItem { | ||
| index, | ||
| blob: *blob, | ||
| kzg_commitment: *commitment, | ||
| kzg_proof: *proof, | ||
| }, | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
this should be an IntoIter impl instead
Comment on lines
+11
to
+29
| #[cfg(feature = "kzg")] | ||
| use crate::BlockNumHash; | ||
| #[cfg(feature = "serde")] | ||
| use alloc::string::String; | ||
| #[cfg(not(feature = "std"))] | ||
| use alloc::vec::Vec; | ||
|
|
||
| #[cfg(feature = "kzg")] | ||
| use alloy_primitives::FixedBytes; | ||
| use alloy_primitives::{bytes::BufMut, B256}; | ||
| use alloy_rlp::{Decodable, Encodable}; | ||
| #[cfg(feature = "kzg")] | ||
| use c_kzg::KzgProof; | ||
| #[cfg(feature = "serde")] | ||
| use core::str::FromStr; | ||
| #[cfg(feature = "serde")] | ||
| use serde::Deserialize; | ||
| #[cfg(feature = "kzg")] | ||
| use sha2::{Digest, Sha256}; | ||
| #[cfg(feature = "kzg")] |
There was a problem hiding this comment.
none of these should be necessary, this makes it very hard to read.
please use full paths instead, this way no import is required
|
Superseded by #1334 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1255